Difference between revisions of "Site copy issues requiring changes in code"

From Dreamwidth Notes
Jump to: navigation, search
m (added string)
(→‎Review / Migrate to Zilla: s/Bugzilla/GHI/)
 
(19 intermediate revisions by 8 users not shown)
Line 1: Line 1:
−
This is a page for members of the [[site copy team]] to note down changes that they think need to be made to site copy that will include changes to code, rather than just changing translation strings. For instance, this could be if a specific string needs an argument passing to it, if a new string needs adding or deleting, etc.
+
This is a page for members of the [[site copy team]] to list changes that they think need to be made to site copy that will include changes to code, rather than just changing translation strings. For instance, if a specific string needs an argument passing to it, or if a new string needs adding or deleting.
  
−
* /allpics.bml.nopics.text.other2 needs a username passed to it, so we can change it to "<dwuser>username</dwuser> has not uploaded any icons..." for consistency.
+
==New==
−
* the BETA warning on /openid/ needs removing.
+
−
* /changeemail.bml - could we have "Edit Profile" linking to the edit profile page?
+
−
* /changepassword.bml.forcechange previously had bml in the translation strings.  The string needs &lt;p&gt; tags putting around it in the code.
+
−
* /community/moderate.bml.choice.bkapprove  and /community/moderate.bml.choice.bkreject  need killing and replacing with hard-coded values, since they contain only code.
+
−
* /transfer.bml - this has .title twice at the top of the page.  One could be removed?
+
−
* on /directorysearch.bml there is a .date and a .day string; day isn't currently referenced anywhere, but .date looks weird ("updated in last date" vs "updated in last day") - I suggest deleting .date string and replacing with .day.
+
−
* /edittags.bml.users needs a username passed to it, so we can change it to "<dwuser>username</dwuser>'s tags:" for consistency.
+
−
* /lostinfo.bml.lostpassword.text has the word Dreamwidth hardcoded into the text, and should probably be changed to [[sitename]].
+
  
 +
Issues that haven't been reviewer yet.
 +
 +
==Deferred==
 +
 +
Leaving these for now, since support related pages are probably going to be re-written when we better know what support policies and procedures will be.
 +
 +
The following is the list of strings containing <?p =and/or= p?>, as per <dwstaff>denise</dwstaff>.
 +
 +
* /support/see_request.bml.goback.text
 +
* /support/see_request.bml.important.notes.text
 +
 +
==Migrated to Zilla==
 +
 +
Issues that have been migrated to [[Bugzilla]].
 +
 +
* <code>/changepassword.bml.forcechange</code> previously had bml in the translation strings.  The string needs &lt;p&gt; tags putting around it in the code.
 +
* <code>/community/moderate.bml.choice.bkapprove</code> and <code>/community/moderate.bml.choice.bkreject</code> need killing and replacing with hard-coded values, since they contain only code.
 +
* <code>/transfer.bml</code> -- This has .title twice at the top of the page.  One could be removed?
 +
* <code>/edittags.bml.users</code> needs a username passed to it, so we can change it to "<dwuser>username</dwuser>'s tags:" for consistency.
 +
* <code>/lostinfo.bml.lostpassword.text</code> has "Dreamwidth" hardcoded into the text, and should probably be changed to <code><nowiki>[[sitename]]</nowiki></code>.
 +
** Also: <code>/tools/textmessage.bml.enter.user.text2</code>
 +
** Also: <code>event.user_new_entry.any</code> ([http://bugs.dwscoalition.org/show_bug.cgi?id=777 Zilla 777])
 +
** Also: <code>event.user_new_entry.user</code> ([http://bugs.dwscoalition.org/show_bug.cgi?id=777 Zilla 777])
 +
* <code>http://www.dreamwidth.org/talkpost_do.bml</code> has the title 'Error' twice -- one could be removed.
 +
* <code>poll.error.notvalid</code> should link to the email confirmation page.
 +
* <code>/tools/memories.bml.error.noentries.body</code> -- This uses "the user" thrice and would be less awkward with <code><nowiki>[[user]]</nowiki></code> than with "the account" as a replacement.
 +
* <code>/tools/textmessage.bml.error.unavailable.notsetup</code> -- Can "this user" be changed to <nowiki>[[user]]</nowiki>?
 +
 +
== Review / Migrate to GHI ==
 +
 +
These need to be reviewed for validity, then for entering into GHI.
 +
 +
* The BETA warning on <code>/openid/</code> needs removing.
 +
* <code>/changeemail</code> -- Could we have "Edit Profile" linking to the edit profile page?
 +
 +
==Not migrated==
 +
 +
These have been looked at and been deemed not to need fixing.
 +
 +
* on /directorysearch.bml there is a .date and a .day string; day isn't currently referenced anywhere, but .date looks weird ("updated in last date" vs "updated in last day") - I suggest deleting .date string and replacing with .day.
 +
** I can't see any issue. I'm seeing .day referenced where it should be. Am I missing something?
 +
*** that's rather bizarre; it's now fixed.  I suppose disregard everything I said originally!
 +
* /manage/emailpost.bml.help.text1: it would be helpful if "allowed sender addresses" linked to the place where you manage those.
 +
** As far as I can see, the only way to get to http://www.dreamwidth.org/manage/emailpost.bml?mode=help is via http://www.dreamwidth.org/manage/emailpost.bml so it seems superfluous to me to be linking back.
 +
* /lostinfo_do.bml.lostpasswordmail.part3 has "This information was requested on the website from <nowiki>[[remoteip]]</nowiki>." -- can/should it be <nowiki>[[sitename]]</nowiki> rather than "the website"?
 +
** Just looking at this, and the context that it's used in, I don't think this needs changing. It's part of an email that has already mentioned the sitename further up.
 +
* /manage/circle/add.bml.confirm.text1.news could the "it" be replaced something like "<nowiki>[[user]]</nowiki>'s"?"
 +
** We're phasing out news type journals, so there's no point updating this.
  
−
[[category:documentation]]
+
[[Category: Documentation]]

Latest revision as of 13:10, 1 August 2014

This is a page for members of the site copy team to list changes that they think need to be made to site copy that will include changes to code, rather than just changing translation strings. For instance, if a specific string needs an argument passing to it, or if a new string needs adding or deleting.

New

Issues that haven't been reviewer yet.

Deferred

Leaving these for now, since support related pages are probably going to be re-written when we better know what support policies and procedures will be.

The following is the list of strings containing <?p =and/or= p?>, as per [info]denise.

  • /support/see_request.bml.goback.text
  • /support/see_request.bml.important.notes.text

Migrated to Zilla

Issues that have been migrated to Bugzilla.

  • /changepassword.bml.forcechange previously had bml in the translation strings. The string needs <p> tags putting around it in the code.
  • /community/moderate.bml.choice.bkapprove and /community/moderate.bml.choice.bkreject need killing and replacing with hard-coded values, since they contain only code.
  • /transfer.bml -- This has .title twice at the top of the page. One could be removed?
  • /edittags.bml.users needs a username passed to it, so we can change it to "[info]username's tags:" for consistency.
  • /lostinfo.bml.lostpassword.text has "Dreamwidth" hardcoded into the text, and should probably be changed to [[sitename]].
    • Also: /tools/textmessage.bml.enter.user.text2
    • Also: event.user_new_entry.any (Zilla 777)
    • Also: event.user_new_entry.user (Zilla 777)
  • http://www.dreamwidth.org/talkpost_do.bml has the title 'Error' twice -- one could be removed.
  • poll.error.notvalid should link to the email confirmation page.
  • /tools/memories.bml.error.noentries.body -- This uses "the user" thrice and would be less awkward with [[user]] than with "the account" as a replacement.
  • /tools/textmessage.bml.error.unavailable.notsetup -- Can "this user" be changed to [[user]]?

Review / Migrate to GHI

These need to be reviewed for validity, then for entering into GHI.

  • The BETA warning on /openid/ needs removing.
  • /changeemail -- Could we have "Edit Profile" linking to the edit profile page?

Not migrated

These have been looked at and been deemed not to need fixing.

  • on /directorysearch.bml there is a .date and a .day string; day isn't currently referenced anywhere, but .date looks weird ("updated in last date" vs "updated in last day") - I suggest deleting .date string and replacing with .day.
    • I can't see any issue. I'm seeing .day referenced where it should be. Am I missing something?
      • that's rather bizarre; it's now fixed. I suppose disregard everything I said originally!
  • /manage/emailpost.bml.help.text1: it would be helpful if "allowed sender addresses" linked to the place where you manage those.
  • /lostinfo_do.bml.lostpasswordmail.part3 has "This information was requested on the website from [[remoteip]]." -- can/should it be [[sitename]] rather than "the website"?
    • Just looking at this, and the context that it's used in, I don't think this needs changing. It's part of an email that has already mentioned the sitename further up.
  • /manage/circle/add.bml.confirm.text1.news could the "it" be replaced something like "[[user]]'s"?"
    • We're phasing out news type journals, so there's no point updating this.
Retrieved from "http://wiki.dreamwidth.net/wiki/index.php?title=Site_copy_issues_requiring_changes_in_code&oldid=12035"