Difference between revisions of "Reviewing Pull Requests"

From Dreamwidth Notes
Jump to: navigation, search
(Created page with "All pull requests need to be reviewed before they are merged into the main == Finding Pull Requests == Pull requests can be found for Dreamwidth repositories at these locat...")
 
(+fu's dw-dev post re files changed tab)
 
Line 1: Line 1:
All pull requests need to be reviewed before they are merged into the main  
+
All pull requests need to be reviewed before they are merged into the main development branch.
  
 
== Finding Pull Requests ==
 
== Finding Pull Requests ==
Line 7: Line 7:
 
* [https://github.com/dreamwidth/dw-free/pulls dw-free]
 
* [https://github.com/dreamwidth/dw-free/pulls dw-free]
 
* [https://github.com/dreamwidth/dw-nonfree/pulls dw-nonfree]
 
* [https://github.com/dreamwidth/dw-nonfree/pulls dw-nonfree]
 +
 +
 +
== Reviewing Pull Requests ==
 +
 +
When leaving comments on a pull request, <dwuser>fu</dwuser> [http://dw-dev.dreamwidth.org/135934.html says that using the Files Changed tab] is much nicer than going through every commit one-by-one.
  
 
[[Category: Development]]
 
[[Category: Development]]
 
[[Category: Git]]
 
[[Category: Git]]

Latest revision as of 11:25, 12 March 2013

All pull requests need to be reviewed before they are merged into the main development branch.

Finding Pull Requests

Pull requests can be found for Dreamwidth repositories at these locations:


Reviewing Pull Requests

When leaving comments on a pull request, [info]fu says that using the Files Changed tab is much nicer than going through every commit one-by-one.