Newbie Guide for Windows People Working on Minor Bugs

From Dreamwidth Notes
Revision as of 10:28, 24 August 2012 by Ninetydegrees (Talk | contribs)

Jump to: navigation, search
Warning: This guide is currently being rewritten to reflect the new workflow. Some things may be unclear, some things may no longer be relevant, some things may be missing. Please be patient.
Note: Feel free to correct, add, expand, anything that could make this better and clearer. ^_^


What do you need and why?

Because we're on Windows, we have to use quite a number of tools to access and manage things so this part might seem a little daunting. The good news is that 1) we're used to being flexible and resourceful, right? 2) once you've got everything set up things will be much simpler.

So what do we need?


  1. We need a Dreamhack where we'll clone the Dreamwidth code. Think of it as an online mirror of the Dreamwidth site.
  2. We need a Github account to be able to clone the Dreamwith repository code into our Dreamhack and fetch updates. This is our code source.
  3. We need PuTTY to connect GitHub to our Dreamhack, and to access and manage it. PuTTY is our center of command. We can't do anything without it.
  4. We need WinSCP to visualize the files on our Dreamhack and be able to open them in a text editor.
  5. We need a text editor to edit our files.
  6. We need a Bugzilla account to find bugs, files bugs and upload patches.


Get a Dreamhack

  • Apply for a Dreamhack by filling this form. The two important fields are 'your desired username' and 'your email address'. Your username is used to manage your Dreamhack and to create the URL where your Dreamhack will be located at so you can pick anything. Your email address is used to send you a welcome e-mail which contains important information as well as various alerts. You can pick any of your existing email addresses or choose to create an email account entirely devoted to your development work.
  • Once you're done, you should get an e-mail with your login username and a password. Don't lose it.


Create an account on GitHub

  • Go to http://www.github.com/, click on 'sign up and pricing' and create a free account. I suggest you pick a username people are familiar with. Ideally the same username you'll have on your Bugzilla account.


Install PuTTY

  • Download 'Windows installer for everything except PuTTYtel' .exe file at PuTTY and install it.
  • Run PuTTY. In the configuration window, enter "hack.dreamwidth.net" for the host name. Go to Connection/Data and enter the username/login given to you in the welcome e-mail. It should be something like dh-username.
  • Click on Open. If you get a pop-up message about a key, click Yes.
  • Enter the password given to you in the welcome e-mail when asked. Note that no characters are displayed and the cursor won't move. It's normal.
  • Change your password by typing:
passwd
  • Your default Dreamhack account is called system. Type this to set its password:
$LJHOME/bin/upgrading/make_system.pl


Install WinSCP

  • Install WinSCP. During the installation, you may be asked about the mode you prefer: Commander and Explorer. Commander works like an FTP client: a partitioned window with your computer files on one side and the Dreamhack files on the other. Explorer will only display your Dreamhack files and works like Windows's Explorer. I prefer this mode because I rarely need to access my computer files but choose what's easiest for you.
  • Use "hack.dreamwidth.net" for the host name. Enter your username and your new password. Click on Save then on Login.


Get a good text editor

While you can use Notepad, I recommend Notepad++ instead. It's free, simple and will make editing much easier.


Create a Bugzilla account

  • As [info]mark explained here, go to Name and Password and enter your name following this format: Name [:username]. 'Name' can be your real name, a nickname, your username again, etc. You don't have to give your real name if you don't want to.

Setting Things Up

On your GitHub account

You need to fork the Dreamwidth code onto your own account. Forking is like cloning and branching. It will copy the code and also label your copy as being a branch (a fork) of the original Dreamwidth code.


On your Dreamhack

Now you need to 'import' both of these onto your Dreamhack. The free part goes into (~/dw/*) while the non-free part goes into (~/dw/ext/dw-nonfree/*.

  • Open PuTTY and type this to kill any process which might be running and stop your hack:
killall worker-manager
stop-apache
  • Then this to move your current code to username-xx:
mv $LJHOME $LJHOME-xx

FIXME: is this necessary for new users?

  • Type this to clone your GitHub code onto your Dreamhack (replace USERNAME with your GitHub username):
git clone https://USERNAME@github.com/USERNAME/dw-free.git $LJHOME
  • Then this to link the repo with the original DW repo on GitHub:
cd $LJHOME
git remote add dreamwidth https://github.com/dreamwidth/dw-free
git fetch dreamwidth
git branch --set-upstream develop dreamwidth/develop 
git branch --set-upstream master dreamwidth/master
  • Now let's do the same thing with the non-free part of Dreamwidth:
cd $LJHOME/ext
git clone https://USERNAME@github.com/USERNAME/dw-nonfree.git
cd dw-nonfree
git remote add dreamwidth https://github.com/dreamwidth/dw-nonfree
git fetch dreamwidth
git branch --set-upstream develop dreamwidth/develop 
git branch --set-upstream master dreamwidth/master
cd ..

FIXME: add last two steps.


Further steps on your Dreamhack

These are not mandatory but will make your life easier.

Give special abilities to your system account

Get rid of invite codes

  • In WinSCP, go to /dw/cvs/local/etc/, and double-click on config.pl. Find $USE_ACCT_CODES = 1; and change 1 to 0. Save your file.
  • In PuTTY, type this to make the changes go live on your Dreamhack:

FIXME


Making sure things are up-to-date

Updating your code

  • Code is committed by developers all the time. You must regularly update your repositories with the pull command:

FIXME


Updating your database

FIXME


Before You Edit Anything

Find or File a Bug

Some of these bugs won't appear to require 'minor' effort to you. It's normal. Try to find small bugs among them: minor modifications to be done on one of the site pages (text to be modified; elements to be added, removed or moved; elements to be hidden from some categories of users, etc.).
  • To assign a bug to yourself, enter your Bugzilla e-mail address in Assign To and set the status to IN_PROGRESS.
To make this easier, you can also use of [info]fu's Greasemonkey scripts: Dreamwidth Bug Grabber. Click on (grab!) next to Assign To and this will edit it and Status for you. Click on Save Changes of course.

Create a Patch

FIXME

Edit Files

  • Use WinSCP to open the file(s) you need to edit.
  • If you're working on site pages, you're working on .bml files. These are in ~dw/cvs/dw-free/htdocs/ or one of the subsequent folders. You'll see that their names correspond to the URLs of site pages. These files may use .pm modules/widgets which are in ~dw/cvs/dw-free/cgi-bin/DW/ or ~dw/cvs/dw-free/cgi-bin/LJ/.
  • For text strings which are not in ~dw/cvs/dw-free/htdocs/xxx.bml.text files, see ~dw/cvs/dw-free/bin/upgrading/en.dat.
  • For more specific searches, you can use the grep command: grep [option(s)] pattern [file(s)]

Interesting options:

-E: match using extended regular expressions -F: match using fixed strings -r: recursive -i: case insensitive -l: filename only -n: add relative line number

Examples:

grep -ri "find this text" * | more
This will search for "find this text" in all files.
grep -rl print_entry $LJHOME/bin/upgrading/s2layers
This will search for files containing "print_entry" in the /s2layers folder.

Test Your Changes on Your Dreamhack

  • In PuTTY, stop your Dreamhack:
cd $LJHOME
stop-apache
  • Update your database:

FIXME

  • Start your Dreamhack again:
start-apache
  • Go to your Dreamhack and test. Edit the files again in WinSCP if more changes are needed. Go through these steps again to test your new changes.


Submit Your Patch

Update & Save Your Patch

FIXME

Upload Your Patch to Bugzilla

  • Click on 'Add an Attachment' to attach your patch. Add a description, check 'patch' and set Flags/Commit and Flags/Review to ?. Feel free to add a comment if you have questions or remarks. Click on Submit.
To help you with this, you can use one of [info]fu's Greasemonkey scripts: Dreamwidth Patch Upload Defaults. This will automatically check 'patch' and set the flags for you.
  • Wait for someone to review and commit your patch. You're done. :)

More: Troubleshooting Tips

Issues With Text Strings

  • As [info]denise explained here, you need to delete old text strings and create new ones when you edit .text files or en.dat instead of simply editing the text. If the change isn't critical - the string doesn't need to be renamed or the text change is minor - it's better to notify the site copy team so that text can be changed locally and the original file left alone.
  • If text you've modified doesn't appear on the site after a code push, append ?uselang=debug to the page URL to make sure it's using the right string. If it is and it still doesn't display after a while, comment on [info]dw_maintenance.

Starting Over


References